Refactor v1alpha2 Linux namespace definitions #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feature/refactor-template-namespaces
branch
from
a3c67b9 to
fb62c3d
Compare
chrisdoherty4
force-pushed
the
feature/refactor-template-namespaces
branch
from
fb62c3d to
cfd9232
Compare
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 51.10% 51.10%
=======================================
Files 33 33
Lines 1454 1454
=======================================
Hits 743 743
Misses 665 665
Partials 46 46 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
moadqassem
reviewed
Oct 24, 2023
chrisdoherty4
force-pushed
the
feature/refactor-template-namespaces
branch
2 times, most recently
from
a42b9aa to
92af321
Compare
jacobweinstock
approved these changes
Oct 25, 2023
Signed-off-by: Chris Doherty <[email protected]>
Signed-off-by: Chris Doherty <[email protected]>
jacobweinstock
force-pushed
the
feature/refactor-template-namespaces
branch
from
92af321 to
23df80e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of Linux namespaces (see https://man7.org/linux/man-pages/man7/namespaces.7.html). Containers can be configured to run inside the bounds of precreated namespaces. The original v1alpha2 API allowed users to specify a network namespace only, but we have already acquired a use-case for the PID namespace.
This change refactors the v1alpha2 API (unreleased) to accommodate future namespace customization.